Nexus caller timeouts #2760
Nexus caller timeouts #2760
Conversation
|
Can we add some tests like we have for activity to verify the parameter is properly wired through and respected |
We have coverage in NexusWorkflowTest.java. |
| Assert.assertTrue("OPERATION_TIMEOUT should be positive", operationTimeoutMs > 0); | ||
|
|
||
| // Sleep longer than schedule-to-start timeout to trigger the timeout | ||
| Thread.sleep(2000); |
There was a problem hiding this comment.
Should be able to use testWorkflowRule.sleep here to avoid waiting real time in the time skipping test server, but I would prefer the test not use a sleep and just wait for the condition to be true. Should be possible to wait for the operation to fail by looking at the workflow describe output no?
NexusWorkflowTest.java doesn't use the Java SDK so it is not providing coverage of the SDK |
|
you also need to update |
maciejdudko
left a comment
maciejdudko
left a comment
There was a problem hiding this comment.
I left a few comments about timeout calculation in test server but otherwise looks good.
| long elapsedSeconds = Timestamps.between(scheduledTime, currentTime).getSeconds(); | ||
| long elapsedMillis = elapsedSeconds * 1000; |
There was a problem hiding this comment.
This rounds off milliseconds from the difference. At the extreme, a sub-second timeout will be rounded to zero.
| long elapsedSeconds = Timestamps.between(scheduledTime, currentTime).getSeconds(); | |
| long elapsedMillis = elapsedSeconds * 1000; | |
| long elapsedMillis = com.google.protobuf.util.Durations.toMillis( | |
| Timestamps.between(scheduledTime, currentTime)); |
| // Calculate minimum of all applicable timeouts | ||
| Long remainingMillis = null; | ||
|
|
||
| if (!isStarted && scheduledEvent.hasScheduleToStartTimeout()) { |
There was a problem hiding this comment.
ScheduleToStartTimeout should not be part of the calculation here.
| com.google.protobuf.util.Durations.toMillis( | ||
| scheduledEvent.getScheduleToCloseTimeout()); | ||
| if (scheduleToCloseMillis > 0) { | ||
| long remaining = scheduleToCloseMillis - elapsedMillis; |
There was a problem hiding this comment.
This code should handle the situation where elapsedMillis is larger than scheduleToCloseMillis for some reason, just for extra safety.
| long remaining = scheduleToCloseMillis - elapsedMillis; | |
| long remaining = Math.max(1, scheduleToCloseMillis - elapsedMillis); |
| long remaining = startToCloseMillis - elapsedMillis; | ||
| remainingMillis = | ||
| (remainingMillis == null) ? remaining : Math.min(remainingMillis, remaining); |
There was a problem hiding this comment.
StartToCloseTimeout should not have elapsed time subtracted.
| long remaining = startToCloseMillis - elapsedMillis; | |
| remainingMillis = | |
| (remainingMillis == null) ? remaining : Math.min(remainingMillis, remaining); | |
| remainingMillis = | |
| (remainingMillis == null) ? startToCloseMillis : Math.min(remainingMillis, startToCloseMillis); |
3 participants
What was changed
ScheduleToStartTimeoutandStartToCloseTimeoutfor Nexus operations in the Java SDK and test server.timeoutNexusOperation()pollNexusTaskQueue()and use the correct header formatNOTE: Do not merge until the API is tagged.